Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use ubuntu-24.04 again for release #847

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

mkniewallner
Copy link
Collaborator

@mkniewallner mkniewallner commented Sep 6, 2024

We had to go back to ubuntu-22.04 on #800 and #801. The issue was that we did not install a specific Python version, so we defaulted to the default one provided by the image, which ends up being externally managed.

Smoke-testing the release workflow in https://github.com/fpgmaas/deptry/actions/runs/10753197835/job/29822356943 and it now works as expected.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.1%. Comparing base (45a9891) to head (de75e22).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #847   +/-   ##
=====================================
  Coverage   92.1%   92.1%           
=====================================
  Files         37      37           
  Lines        992     992           
  Branches     175     175           
=====================================
  Hits         914     914           
  Misses        62      62           
  Partials      16      16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkniewallner mkniewallner force-pushed the ci/put-back-ubuntu-24.04-release branch from 1ae2a6e to 7d20864 Compare September 7, 2024 17:32
@mkniewallner mkniewallner marked this pull request as ready for review September 7, 2024 17:32
@mkniewallner mkniewallner requested a review from fpgmaas September 7, 2024 17:32
@mkniewallner mkniewallner force-pushed the ci/put-back-ubuntu-24.04-release branch from 7d20864 to de75e22 Compare September 11, 2024 11:33
@mkniewallner
Copy link
Collaborator Author

Tested release workflow again following the switch to setup-uv, it works as expected, so going to merge this one.

@mkniewallner mkniewallner merged commit 49c5e7c into main Sep 11, 2024
40 checks passed
@mkniewallner mkniewallner deleted the ci/put-back-ubuntu-24.04-release branch September 11, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant